Hello,
I saw that Rodolphe had committed items a few days ago and today I cloned from Git and want to report back. Both PDMRotator.ino and PDMShutter.ino compiled cleanly and upload fine. The usual stuff to get shutter working after a power off.. open a little with rocker then close with switch til it stops. On first connect to POTH after that shutter showed as Unknown. Just clicked Close and all was then well.
So far as I can tell everything if fine function wise. From ACP issuing a Home homes the dome but exactly as before leaves a lingering slew which must be stopped from ACP's control button. Failure to do this and then asking for another slew results in the Rotator having to be power-cycled to function again. I suspect something in the ASCOM driver side here. I do have workarounds in my ACP startup/shutdown/weather scripts which keep everything happy. There remains something funky in Dome.FindHome and reporting of athome. No different than before.
I also noticed that from POTH using setup rotator shows as version 2.0.0 and shutter version is blank. Also!! Now in Rotator settings the dome calibration numbers are what was in the new ino not my values. Doing a home then calibrate proceeds normally but values are not updated. Not a problem as my numbers were only 30 steps different than what is there now.
Also in POTH setup shutter both speed and accel are 0. Set does nothing.
So it does appear that the latest Git commit has ASCOM driver and the firmware slightly out of sync. I have no ill effects functionally myself but felt it important to report.
I have slewed/slaved all over the sky and run weather safety and shutdown/startup scripts mimicking an observing run and all has been fine. So my report is that all is OK with a bit of out of sync with ASCOM driver. I do not know how to compile ASCOM so will need to rely on installers as they update.
Thanks everyone for the hard work!!
Ron
Adding the rounding on the proper motor step value seems to solve the issue. I've set it to 8 for now and all my test seem to work. That of course add a little bit of extra error on the pointing so a goto 0.1 sends you to 0.12 and from there a goto 0 sends you to 359.99
This is because in this firmware all move are relative. I'll try to improve it
Also these values are for my very small test rig .. on a real dome as the number of steps per rotation is a lot bigger the error will be a lot smaller.
I pushed the new changes to the git repo so if you could test with this new version and let me know if it fixes your issue.
Regards, Rodolphe